[ 
https://issues.apache.org/jira/browse/SOLR-15902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17472868#comment-17472868
 ] 

Houston Putman edited comment on SOLR-15902 at 1/11/22, 4:38 PM:
-----------------------------------------------------------------

I agree that there should not be random jar files checked into the test 
resources. They should definitely be generated as a part of the test build 
(though I'm not exactly sure how this should be done).

Luckily this is not necessary to fix the broken test, but it should be carried 
out as a separate issue.


was (Author: houston):
I agree that there should not be random jar files checked into the test 
classes. They should definitely be generated as a part of the test build 
(though I'm not exactly sure how this should be done).

Luckily this is not necessary to fix the broken test, but it should be carried 
out as a separate issue.

> PackageManagerCLITest.testPackageManager fails on main
> ------------------------------------------------------
>
>                 Key: SOLR-15902
>                 URL: https://issues.apache.org/jira/browse/SOLR-15902
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Gus Heck
>            Assignee: Ishan Chattopadhyaya
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> The version for main has advanced, but this test contains a package with an 
> upper version constraint of 9 and main has advanced to 10.0 It also contains 
> two binary jar files containing classes with a fullstory package and no 
> source code. There is a manifest.json, but there is also another copy baked 
> into one of the jars. This needs to be cleaned up such that these jar files 
> (containing packages to be installed during tests) can be rebuilt by a build 
> target and are not checked in as binary jars. (with a .tmp ending). Also all 
> classes run by the build should exist as source code. If the code for these 
> classes is owned by Fullstory, they should be replaced with something owned 
> by Apache.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to