magibney opened a new pull request #513: URL: https://github.com/apache/solr/pull/513
See: [SOLR-9376](https://issues.apache.org/jira/browse/SOLR-9376) This PR fixes test coverage to cover both cloud and standalone mode operation of the `[json]` and `[xml]` DocTransformers. Testing could/should definitely be expanded, and there may be some edge cases not accounted for. (The bulk of the work was actually in updating the test (such as it was) to cover cloud mode. Very tricky because this issue deals with serialization per se, so you need to bypass a bunch of the common test abstractions that purposefully hide serialization details. Wistfully thinking of [SOLR-11872](https://issues.apache.org/jira/browse/SOLR-11872) :slightly_smiling_face:) There was a false start, reverted. I left the commit history for clarity and comparison, but I think the approach ultimately taken (after the false start) is much better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
