HoustonPutman commented on a change in pull request #509:
URL: https://github.com/apache/solr/pull/509#discussion_r782556509
##########
File path: solr/contrib/prometheus-exporter/bin/solr-exporter
##########
@@ -86,6 +86,10 @@ for JAR in $(find "$BASEDIR"/../../dist -name
'solr-solrj-*.jar')
do
CLASSPATH="$CLASSPATH":"$JAR"
done
+for JAR in $(find "$BASEDIR"/../../server/solr-webapp/webapp/WEB-INF/lib/
-name '*.jar')
+do
+ CLASSPATH="$CLASSPATH":"$JAR"
Review comment:
Mike mentioned offline that the CLASSPATH `/*` notation doesn't recurse
into directories, like `find` does. However we don't use that functionality. So
we should be safe.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
