Caa52 opened a new pull request #529: URL: https://github.com/apache/solr/pull/529
https://issues.apache.org/jira/browse/SOLR-15257 # Description Currently, we use the `getTopFilter` method in Filter to access a Query based on a DocSet. This is done via calling Filter's main method `getDocIdSet` and then calling an `iterator()`. However, with Filter going away, we still need the ability to have a Query based on a DocSet. Removing Filter requires reducing and possibly eliminating dependencies on `getDocIdSet` and implies that changes must be made to all callers that call Filter specific methods as well. # Solution To access a Query based on a DocSet without going through Filter: - Create a new Query, `DocSetQuery`, that emulates the behavior of Filter - Delete all calls to `getDocIdSet` which is Filter's main method - Implement change to DocSet's API by replacing `getTopFilter` with `makeQuery` to help go from DocSet to a Query of the DocSet - Delete Filter class # Tests Refactored all existing tests that were affected as a result of deleting Filter. Expanded test coverage by updating test suite to account for changes made. All tests are passing. # Checklist Please review the following and check all that apply: - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
