risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r789003197
##########
File path:
solr/core/src/test/org/apache/solr/core/TestBackupRepositoryFactory.java
##########
@@ -132,13 +131,7 @@ public void testRepositoryConfig() {
attrs.put("location", "/tmp");
plugins[0] = new PluginInfo("repository", attrs);
}
- {
- Map<String, Object> attrs = new HashMap<>();
- attrs.put(CoreAdminParams.NAME, "boom");
- attrs.put(FieldType.CLASS_NAME, HdfsBackupRepository.class.getName());
- attrs.put("location", "/tmp");
- plugins[1] = new PluginInfo("repository", attrs);
- }
Review comment:
Not sure I understand this removal? This changes the test for no reason?
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysis",
"org.apache.solr.cloud",
"org.apache.solr.core",
+ "org.apache.solr.handler",
Review comment:
Agree with @madrob here
##########
File path: solr/contrib/hdfs/build.gradle
##########
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+apply plugin: 'java-library'
+
+description = 'HDFS Package'
+
+dependencies {
+
+ implementation project(':solr:core')
+
+
+ //implementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false }
+ implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false
}
+ implementation ('org.apache.hadoop:hadoop-auth') { transitive = false }
+ implementation ('org.apache.hadoop:hadoop-common') { transitive = false }
+ implementation ('org.apache.hadoop:hadoop-hdfs-client') { transitive = false
}
+ implementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false }
+
+
+
+ api('com.github.ben-manes.caffeine:caffeine', {
+ exclude group: "org.checkerframework", module: "checker-qual"
+ })
+
+ // Many HDFS tests are using/subclassing test framework classes
+ testImplementation project(':solr:test-framework')
+
+ // hadoop dependencies for tests
+ testImplementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false }
Review comment:
Agreed we should remove the `transitive = false` since it causes some
pain.
##########
File path: gradle/documentation/render-javadoc.gradle
##########
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysis",
"org.apache.solr.cloud",
"org.apache.solr.core",
+ "org.apache.solr.handler",
"org.apache.solr.handler.component",
"org.apache.solr.update.processor",
+ "org.apache.solr.util",
+ "org.apache.solr.search.similarities",
+ "org.apache.solr.search.function",
+ "org.apache.solr.search.facet",
+ "org.apache.solr.schema"
Review comment:
Is this needed?
##########
File path: gradle/validation/rat-sources.gradle
##########
@@ -102,6 +102,12 @@ allprojects {
exclude "src/test-files/META-INF/services/*"
break
+ case ":solr:contrib:hdfs":
Review comment:
Agreed this should be cleaned up. I'd be surprised if any of these test
files are needed for HDFS.
##########
File path: solr/contrib/hdfs/.gitignore
##########
@@ -0,0 +1,2 @@
+# IDEA project file
+hdfs.iml
Review comment:
Agreed this should be removed.
##########
File path: solr/contrib/README.md
##########
@@ -0,0 +1,31 @@
+Apache Solr HDFS Contrib module
Review comment:
Agree w/ @madrob - there is already a `solr/contrib/hdfs/README.md` as
well? Should be consolidated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
