Caa52 commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r790001455
##########
File path: solr/core/src/test/org/apache/solr/search/TestDocSet.java
##########
@@ -556,41 +558,55 @@ public void doFilterTest(IndexReader reader) throws
IOException {
doTestIteratorEqual(da, db);
***/
- DocIdSet da;
- DocIdSet db;
List<LeafReaderContext> leaves = topLevelContext.leaves();
-
// first test in-sequence sub readers
for (LeafReaderContext readerContext : leaves) {
- da = fa.getDocIdSet(readerContext, null);
- db = fb.getDocIdSet(readerContext, null);
-
// there are various ways that disis can be retrieved for each
leafReader; they should all be equivalent.
- doTestIteratorEqual(da.bits(), disiSupplier(da), disiSupplier(db), () ->
a.iterator(readerContext), () -> b.iterator(readerContext));
-
+ doTestIteratorEqual(getExpectedBits(a, readerContext), () ->
a.iterator(readerContext), () -> b.iterator(readerContext));
// set b is SortedIntDocSet, so derivatives should not support
random-access via Bits
Review comment:
Good catch! Thanks 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
