janhoy commented on a change in pull request #557: URL: https://github.com/apache/solr/pull/557#discussion_r790262307
########## File path: solr/core/src/java/org/apache/solr/core/CoreContainer.java ########## @@ -1884,8 +1855,6 @@ public void unload(String name, boolean deleteIndexDir, boolean deleteDataDir, b } catch (InterruptedException e) { Thread.currentThread().interrupt(); throw new SolrException(ErrorCode.SERVER_ERROR, "Interrupted while unregistering core [" + name + "] from cloud state"); - } catch (KeeperException e) { Review comment: Yea, I had some unrelated cleanups in the same commit. This catch is redundant with the `catch (Exception)`- suggested by IDEA. But it disturbs the feature review, so reverted it too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org