madrob commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r790868847
##########
File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java
##########
@@ -26,19 +26,29 @@
import org.apache.lucene.search.ScoreMode;
import org.apache.lucene.search.Scorer;
import org.apache.lucene.search.Weight;
+import org.apache.lucene.util.FixedBitSet;
+import org.apache.solr.util.TestInjection;
import java.io.IOException;
import java.util.Objects;
+/**
+ * A class that accesses Queries based on a DocSet
+ * This class was created as a replacement to DocSet.getTopFilter
+ * which has since been removed with Filter
Review comment:
I don't think we need this? What value will it provide to somebody new
looking at the class?
##########
File path: solr/core/src/java/org/apache/solr/search/DocSetQuery.java
##########
@@ -63,7 +73,20 @@ public int hashCode() {
@Override
public DocSet createDocSet(SolrIndexSearcher searcher) throws IOException {
- return null;
+ return newDocSet(searcher, Math.min(64,(searcher.maxDoc()>>>10)+4));
Review comment:
This doesn't make sense...
Shouldn't it be `return docSet;`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
