[
https://issues.apache.org/jira/browse/SOLR-15953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17481291#comment-17481291
]
Christine Poerschke commented on SOLR-15953:
--------------------------------------------
That's a good catch!
Since {{LTRThreadModule}} does not own the executor it really has no business
trying to shut it down; waiting for the executor to shutdown, yeah, maybe;
actively asking the executor to shutdown, no.
The {{CloseHook}} javadocs helpfully point out that {{addCloseHook}} is to be
used but since nothing calls {{addCloseHook}} for {{LTRThreadModule}} we can
simply remove it as unused I think.
> investigate LTRThreadModule.preClose code
> -----------------------------------------
>
> Key: SOLR-15953
> URL: https://issues.apache.org/jira/browse/SOLR-15953
> Project: Solr
> Issue Type: Task
> Components: contrib - LTR
> Reporter: Christine Poerschke
> Priority: Major
>
> As part of https://github.com/apache/solr/pull/538 [~mdrob] noticed and wrote:
> {code}
> // TODO: Investigate...
> // All uses of setExecutor use the core container's update executor, which
> could impact other cores?
> {code}
> https://github.com/apache/solr/blob/4029a925a68f008dadffed0eb4e6d040daffdcb0/solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRThreadModule.java#L168-L169
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
