epugh commented on pull request #565: URL: https://github.com/apache/solr/pull/565#issuecomment-1021339537
> > why not fix "indexes" spelling now? > > Two "soft" reasons: > > 1. It's hard to imagine anyone caring about "indexes" in particular, but in theory I could imagine someone being unhappy at me "burying" API changes in these PRs since I typically describe them as straightforward conversions/translations. > > 2. Scope creep - there's so much I'd like to see improved in these APIs that if I started going down those rabbit holes now, I'd never have a hope of finishing the conversion to the annotation framework. (e.g. Why not make `SplitCorePayload.ranges` a `List<String>`? Why not unify the use of 'index' and 'core' in some of these commands and property names? Why not add enum support to the annotation framework so we can use it on `SplitCorePayload.splitMethod` etc.) > > > That said, I'd buy the argument that "indexes" is a clear spelling error, and I'd be willing to make an exception for it if you think I should @epugh ? There are 430 results for "Indexes", and honestly, the more I think on it, I think that while "Indices" may be grammatically correct, "Indexes" is really the word we use! At any rate, only 51 "indices" in the source ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
