gerlowskija commented on pull request #565:
URL: https://github.com/apache/solr/pull/565#issuecomment-1021504830


   > There are 430 results for "Indexes", and honestly, the more I think on it, 
I think that while "Indices" may be grammatically correct, "Indexes" is really 
the word we use! At any rate, only 51 "indices" in the source
   
   Well, that's another good reason to leave the spelling as-is for now.  Yikes 
though haha 😬 
   
   > Would it make sense to move the Payload classes into the API classes? I 
think that's the only place they are used?
   
   The only reason I haven't done that yet is that I have some far-off 
aspiration of re-using the payload classes in SolrJ as well.  It'd be really 
nice if each API enumerated the params it accepts in only 1 place that can be 
used on the server and client side alike.  (Bit more detail on this idea 
[here](https://issues.apache.org/jira/browse/SOLR-15187))
   
   If you feel strongly about it, I'm open to moving them inside the API 
classes - I don't want to design too much for a "someday" that may never come. 
Just lmk.  (Either way it should probably be a separate PR since there are a 
bazillion Payload classes and I'm only touching a few of them here.) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to