madrob commented on a change in pull request #553:
URL: https://github.com/apache/solr/pull/553#discussion_r792068327
##########
File path:
solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java
##########
@@ -41,6 +41,10 @@ public boolean reject(Thread t) {
return true;
} else if (name.startsWith("nioEventLoopGroup")) {
return true; // netty threads waiting for a web server stop confirm that
won't happen
+ } else if (name.startsWith("globalEventExecutor")) { // HADOOP-11219
(Hadoop and Netty 4)
+ return true;
+ } else if (name.startsWith("Command processor")) { // HDFS-14997
Review comment:
Why does this leak, it's a daemon thread?
https://github.com/apache/hadoop/blob/03cfc852791c14fad39db4e5b14104a276c08e59/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPServiceActor.java#L1309
##########
File path:
solr/test-framework/src/java/org/apache/solr/util/BadHdfsThreadsFilter.java
##########
@@ -41,6 +41,10 @@ public boolean reject(Thread t) {
return true;
} else if (name.startsWith("nioEventLoopGroup")) {
return true; // netty threads waiting for a web server stop confirm that
won't happen
+ } else if (name.startsWith("globalEventExecutor")) { // HADOOP-11219
(Hadoop and Netty 4)
Review comment:
This... shouldn't leak? Why does it leak? According to
https://netty.io/4.0/api/io/netty/util/concurrent/GlobalEventExecutor.html it
will clean itself up after a second of inactivity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
