dsmiley commented on pull request #559: URL: https://github.com/apache/solr/pull/559#issuecomment-1021842200
> use `!` rather than `== false`, no? Using `== false` is especially prevalent in Lucene and it's a deliberate choice; I prefer it as well. It reads in a more obvious way. The single exclamation mark on the left of an expression is visually subtle. A bug was found once long ago where this was deemed the root cause. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
