sonatype-lift[bot] commented on a change in pull request #324: URL: https://github.com/apache/solr/pull/324#discussion_r793853588
########## File path: solr/modules/hdfs/build.gradle ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'HDFS Contrib Module' + +dependencies { + + configurations.all { + exclude group: 'log4j', module: 'log4j' + exclude group: 'commons-logging', module: 'commons-logging' + exclude group: 'org.slf4j', module: 'slf4j-log4j12' + exclude group: 'org.apache.yetus', module: 'audience-annotations' + exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations' + // be conservative on what's added here. Affects *all* configs, including internal ones. + } + + + implementation project(':solr:core') + + // Hadoop dependencies + implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false } + implementation ('org.apache.hadoop:hadoop-auth') { transitive = false } Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/src/java/org/apache/solr/update/HdfsUpdateLog.java ########## @@ -44,9 +44,7 @@ /** * @lucene.experimental Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/build.gradle ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'HDFS Contrib Module' + +dependencies { + + configurations.all { + exclude group: 'log4j', module: 'log4j' + exclude group: 'commons-logging', module: 'commons-logging' + exclude group: 'org.slf4j', module: 'slf4j-log4j12' + exclude group: 'org.apache.yetus', module: 'audience-annotations' + exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations' + // be conservative on what's added here. Affects *all* configs, including internal ones. + } + + + implementation project(':solr:core') + + // Hadoop dependencies + implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false } + implementation ('org.apache.hadoop:hadoop-auth') { transitive = false } + implementation ('org.apache.hadoop:hadoop-common') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs-client') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false } + + // Guava implements the VisibleForTesting annotations + implementation ('com.google.guava:guava') { transitive = false } + + // Caffeine cache to implement HDFS block caching + api('com.github.ben-manes.caffeine:caffeine', { + exclude group: "org.checkerframework", module: "checker-qual" + }) + + // Many HDFS tests are using/subclassing test framework classes + testImplementation project(':solr:test-framework') + + // HdfsCheckindexTool tests reference LuceneTestCase + testImplementation ('org.apache.lucene:lucene-test-framework') + + // hadoop dependencies for tests + testImplementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false } + testImplementation ('org.apache.hadoop:hadoop-common::tests') { transitive = false } + testImplementation ('org.apache.hadoop:hadoop-hdfs::tests') { transitive = false } + testImplementation ('org.apache.hadoop:hadoop-minikdc') { transitive = false } + + testImplementation 'org.apache.logging.log4j:log4j-1.2-api' + + // classes like solr.ICUCollationField, used by NNFailoverTest for example. + testImplementation project(':solr:modules:analysis-extras') + + // required for instantiating a Zookeeper server in tests or embedded + runtimeOnly ('org.xerial.snappy:snappy-java') + + // commons packages needed by test classes + testImplementation('commons-io:commons-io') { transitive = false } + + // Zookeeper dependency - some tests like HdfsCloudBackupRestore need this + implementation ('org.apache.zookeeper:zookeeper') Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/src/java/org/apache/solr/update/HdfsUpdateLog.java ########## @@ -44,9 +44,7 @@ /** * @lucene.experimental Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ########## @@ -30,9 +30,7 @@ /** * @lucene.experimental Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/build.gradle ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'HDFS Contrib Module' + +dependencies { + + configurations.all { + exclude group: 'log4j', module: 'log4j' + exclude group: 'commons-logging', module: 'commons-logging' + exclude group: 'org.slf4j', module: 'slf4j-log4j12' + exclude group: 'org.apache.yetus', module: 'audience-annotations' + exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations' + // be conservative on what's added here. Affects *all* configs, including internal ones. + } + + + implementation project(':solr:core') + + // Hadoop dependencies + implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false } + implementation ('org.apache.hadoop:hadoop-auth') { transitive = false } + implementation ('org.apache.hadoop:hadoop-common') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs-client') { transitive = false } Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/src/java/org/apache/solr/core/backup/repository/HdfsBackupRepository.java ########## @@ -46,10 +46,6 @@ import org.slf4j.Logger; import org.slf4j.LoggerFactory; -/** - * @deprecated since 8.6 - */ -@Deprecated public class HdfsBackupRepository implements BackupRepository { private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/build.gradle ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'HDFS Contrib Module' + +dependencies { + + configurations.all { + exclude group: 'log4j', module: 'log4j' + exclude group: 'commons-logging', module: 'commons-logging' + exclude group: 'org.slf4j', module: 'slf4j-log4j12' + exclude group: 'org.apache.yetus', module: 'audience-annotations' + exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations' + // be conservative on what's added here. Affects *all* configs, including internal ones. + } + + + implementation project(':solr:core') + + // Hadoop dependencies + implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false } + implementation ('org.apache.hadoop:hadoop-auth') { transitive = false } + implementation ('org.apache.hadoop:hadoop-common') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs-client') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false } + + // Guava implements the VisibleForTesting annotations + implementation ('com.google.guava:guava') { transitive = false } + + // Caffeine cache to implement HDFS block caching + api('com.github.ben-manes.caffeine:caffeine', { + exclude group: "org.checkerframework", module: "checker-qual" + }) + + // Many HDFS tests are using/subclassing test framework classes + testImplementation project(':solr:test-framework') + + // HdfsCheckindexTool tests reference LuceneTestCase + testImplementation ('org.apache.lucene:lucene-test-framework') + + // hadoop dependencies for tests + testImplementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false } + testImplementation ('org.apache.hadoop:hadoop-common::tests') { transitive = false } Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java ########## @@ -30,9 +30,7 @@ /** * @lucene.experimental Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. ########## File path: solr/modules/hdfs/build.gradle ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +apply plugin: 'java-library' + +description = 'HDFS Contrib Module' + +dependencies { + + configurations.all { + exclude group: 'log4j', module: 'log4j' + exclude group: 'commons-logging', module: 'commons-logging' + exclude group: 'org.slf4j', module: 'slf4j-log4j12' + exclude group: 'org.apache.yetus', module: 'audience-annotations' + exclude group: 'org.codehaus.mojo', module: 'animal-sniffer-annotations' + // be conservative on what's added here. Affects *all* configs, including internal ones. + } + + + implementation project(':solr:core') + + // Hadoop dependencies + implementation ('org.apache.hadoop:hadoop-annotations') { transitive = false } + implementation ('org.apache.hadoop:hadoop-auth') { transitive = false } + implementation ('org.apache.hadoop:hadoop-common') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs-client') { transitive = false } + implementation ('org.apache.hadoop:hadoop-hdfs') { transitive = false } + + // Guava implements the VisibleForTesting annotations + implementation ('com.google.guava:guava') { transitive = false } Review comment: I've recorded this as ignored for this pull request. If you change your mind, just comment `@sonatype-lift unignore`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
