dsmiley commented on a change in pull request #529:
URL: https://github.com/apache/solr/pull/529#discussion_r793946283



##########
File path: solr/CHANGES.txt
##########
@@ -256,9 +256,8 @@ when told to. The admin UI now tells it to. (Nazerke 
Seidan, David Smiley)
 * SOLR-15209: The old LegacyAssignStrategy has been refactored into the 
SimplePlacementPlugin. This is still the default
   placement policy for Solr. (Houston Putman, Ilan Ginzburg)
 
-* SOLR-15257: Add DocSetQuery in lieu of DocSet.getTopFilter. This issue led 
to removing
-  Filter.java and eliminating all dependencies on its main method getDocIdSet. 
With Filter deleted ,
-  and replaced with Lucene's Query.java, the changes might spark some 
performance optimizations (Collins Abanda, Mike Drob, Tim Potter)
+* SOLR-12336: Remove Filter and SolrFilter, replaced by DocSetQuery which is a 
Query

Review comment:
       I don't think the summary of SOLR-12336 (removal of Filter) shouldn't 
reference DocSetQuery; that had its own issue (SOLR-15257).  Also, the cast of 
characters, if you look at the JIRAs referenced from this umbrella issue, 
included Michael Gibney (SOLR-14185).  I suppose in this one you might mention 
SolrConstantScoreQuery's removal too.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to