[
https://issues.apache.org/jira/browse/SOLR-15962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17484308#comment-17484308
]
David Smiley commented on SOLR-15962:
-------------------------------------
Woops; I didn't mean to push this without peer review! I think tweaked my IDE
settings to prevent this mistake.
Still needs a changes.txt.
There will be a test affected by this when the UH is made the default
highlighter visible in the PR https://github.com/apache/solr/pull/579
solr/core/src/test/org/apache/solr/search/TestSurroundQueryParser.java where I
had to keep using the original highlighter for that specific test. After the
change in this issue, that can use the UH.
> Surround Query Parser sometimes doesn't highlight
> -------------------------------------------------
>
> Key: SOLR-15962
> URL: https://issues.apache.org/jira/browse/SOLR-15962
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
> Components: highlighter
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Minor
>
> From TestSurroundQueryParser
> {noformat}
> "q", "{!surround df=name}k w l",
> "hl", "true",
> "hl.fl", "name",
> "hl.usePhraseHighlighter", "false"
> {noformat}
> This won't work with the unified highlighter because when
> usePhraseHighlighter is disabled as seen above, it relies on Query.visitTerms
> to be implemented properly, which it isn't (a TODO in Lucene for that query).
> Workaround is to not disable usePhraseHighlighter :-) or to use the original
> highlighter.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
