[
https://issues.apache.org/jira/browse/SOLR-14686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17486108#comment-17486108
]
ASF subversion and git services commented on SOLR-14686:
--------------------------------------------------------
Commit 703782d1a1f63e0efa9377dad839c0913c880d37 in solr's branch
refs/heads/main from David Smiley
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=703782d ]
SOLR-14686: fix MDC log clear in SolrCore.close (#583)
this is a fix-up of previous commit for this issue
> Remove log "[coreName]" (logid) which is redundant with MDC
> -----------------------------------------------------------
>
> Key: SOLR-14686
> URL: https://issues.apache.org/jira/browse/SOLR-14686
> Project: Solr
> Issue Type: Improvement
> Components: logging
> Reporter: David Smiley
> Assignee: David Smiley
> Priority: Blocker
> Fix For: 9.0
>
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> SolrCore.logid is used mostly by some log statements within SolrCore to log
> the core name at the start of some (not all) log messages. It pre-dated MDC
> and I believe it's basically obsolete now, and contributes to needless
> logging verbosity. The info levels where this appears if for opening a new
> SolrCore, closing a SolrCore, registering a new searcher, and it's in the
> "requestLog" and thus will show up once for any HTTP request into a core
> (e.g. select, update, etc.). So removing this will disturb anyone parsing
> Solr's logs. Maybe this should wait till 9.0?
> There is _some_ value still because for cross-core join query, any pertinent
> log statements on the "fromIndex" would ideally be reported against that
> core and not the toIndex. That seems too minor to keep this old stuff around
> for though.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
