colvinco commented on a change in pull request #250: URL: https://github.com/apache/solr/pull/250#discussion_r799289796
########## File path: solr/bin/solr ########## @@ -884,8 +887,12 @@ function stop_solr() { sleep 10 fi - CHECK_PID=`ps auxww | awk '{print $2}' | grep -w $SOLR_PID | sort -r | tr -d ' '` - if [ "$CHECK_PID" != "" ]; then + STAT=`ps -o stat='' $SOLR_PID | tr -d ' '` + if [ "$STAT" == "Z" ]; then + # This can happen if, for example, you are running Solr inside a docker container with multiple processes + # rather than running it is as the only service. The --init flag on docker avoids that particular problem. + echo -e "Solr process $SOLR_PID has terminated abnormally. Solr has exited but a zombie process entry remains." Review comment: Fair question. I think you're right that it should exit 1, since something is wrong. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org