[
https://issues.apache.org/jira/browse/SOLR-15959?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17489010#comment-17489010
]
Chris M. Hostetter commented on SOLR-15959:
-------------------------------------------
(I assume you ment SOLR-4718 (linked issue) and not SOLR-1718 ?)
I still don't remember having strong feelings about this, and even if I did at
the time, I don't know .. my current philosophy with most Solr changes is "Try
not to be in the way of progress"
If you feel that deprecating this functionality will make the code better (or
easier to maintain) and no one else can give you strong coutner arguments why
it's a bad idea (or why loading {{solr.xml}} from ZK is really important and
achieves something that can't be achieved any other way) then go for it ... I
am certainly not a person that can think of any arguments against
deprecation/removal.
> Deprecate loading of solr.xml from ZK
> -------------------------------------
>
> Key: SOLR-15959
> URL: https://issues.apache.org/jira/browse/SOLR-15959
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Reporter: Jan Høydahl
> Priority: Major
>
> In SOLR-7735, five years ago (committed by me) we allowed loading of solr.xml
> from zookeeper.
> Part of the motivation back then was to be able to put {{solr.xml}} in a
> central place and not being forced to initialize {{SOLR_HOME}} with that
> file, similar to the goal of SOLR-9575. And perhaps also an easy way to
> update solr.xml.
> However, I think it may have been a mistake that should be deprecated and
> ultimately removed. Why? The {{solr.xml}} file is the "node config" for solr.
> Where you set node-level props that need to be there at early node startup.
> So even if you change the file in ZK, nodes will have not way of reloading
> those plugins dynamically without a restart
> The file may even contain local-node-specific settings that shuold differ
> from node to node. Especially during rolling upgrade, it may be important to
> be able to have a different {{solr.xml}} on the new nodes and on the old
> ones. With property substitution you can do some of that, but you cannot add
> XML tags with a sysprop.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
