Caa52 opened a new pull request #658: URL: https://github.com/apache/solr/pull/658
This is a follow-up improvement to the creation of DocSetQuery, reference https://issues.apache.org/jira/browse/SOLR-15257 In the overriden Scorer in `DocSetQuery.createWeight` we do not currently impose a null check on `docSet`. Implementing a null check on `scorer` here could simplify some of the implementations in `TestFilteredDocIdSet`. This PR also investigates at what seems to be an unnecessary redundancy in `TestFilteredDocIdSet`, i.e `testNullDocIdSet` seemingly functions the same as `testNullIteratorFilteredDocIdSet`, therefore potentially rendering `testNullIteratorFilteredDocIdSet` pointless as is. - [X] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [X] I have created a Jira issue and added the issue ID to my pull request title. - [X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [X] I have developed this patch against the `main` branch. - [X] I have run `./gradlew check`. - [X] I have added tests for my changes. - [X] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
