dsmiley commented on a change in pull request #708:
URL: https://github.com/apache/solr/pull/708#discussion_r814906422
##########
File path: solr/core/src/java/org/apache/solr/handler/sql/SolrSchema.java
##########
@@ -88,7 +88,7 @@ public boolean isClosed() {
protected Map<String, Table> getTableMap() {
String zk = this.properties.getProperty("zk");
CloudSolrClient cloudSolrClient = solrClientCache.getCloudSolrClient(zk);
- ZkStateReader zkStateReader = cloudSolrClient.getZkStateReader();
+ ZkStateReader zkStateReader = ZkStateReader.from(cloudSolrClient);
Review comment:
I said I wouldn't repeat that comment I just wrote but I observe here a
basic/trivial "find" wouldn't find this case. From the GitHub UI it's not
clear is zkStateReader is in fact still needed; perhaps it is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
