dsmiley commented on a change in pull request #705:
URL: https://github.com/apache/solr/pull/705#discussion_r818966572



##########
File path: solr/core/src/java/org/apache/solr/parser/QueryParser.java
##########
@@ -8,25 +8,25 @@
 import java.util.HashSet;
 import java.util.List;
 import java.util.Set;
-
 import org.apache.lucene.analysis.Analyzer;
+import org.apache.lucene.queryparser.charstream.CharStream;
+import org.apache.lucene.queryparser.charstream.FastCharStream;
 import org.apache.lucene.search.BooleanClause;
 import org.apache.lucene.search.Query;
-import org.apache.solr.search.SyntaxError;
 import org.apache.solr.search.QParser;
-
-import org.apache.lucene.queryparser.charstream.CharStream;
-import org.apache.lucene.queryparser.charstream.FastCharStream;
+import org.apache.solr.search.SyntaxError;
 
 public class QueryParser extends SolrQueryParserBase implements 
QueryParserConstants {

Review comment:
       Okay.  Since Lucene has the same concern, we should probably mimick 
them.  See this commit: 
https://github.com/apache/lucene/commit/2cbf261032dc8aca56c846971c090c991ac594a6
 notice that the spotless config expressly excluded these generated files.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to