dsmiley commented on a change in pull request #726:
URL: https://github.com/apache/solr/pull/726#discussion_r819900836
##########
File path: solr/core/build.gradle
##########
@@ -139,12 +139,12 @@ dependencies {
implementation 'org.apache.logging.log4j:log4j-core'
implementation 'org.apache.logging.log4j:log4j-slf4j-impl'
- implementation 'io.dropwizard.metrics:metrics-core'
- implementation ('io.dropwizard.metrics:metrics-graphite', {
+ compileOnlyApi 'io.dropwizard.metrics:metrics-core'
Review comment:
While this change works I assume, I think it's fundamentally wrong to
mis-advertise the proper scope just because of our packaging quirks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
