[ 
https://issues.apache.org/jira/browse/SOLR-16061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17505110#comment-17505110
 ] 

Jan Høydahl commented on SOLR-16061:
------------------------------------

I added some review comments to the PR and committed a few test fixes. Hope you 
have some time to bring this to completion beginning of next week, as this is 
one of the last blockers.

Or we could admit that this was a T-shirt size too large for 9.0 and target 
this for main branch only. Disadvantage is that it touches so many classes that 
backporting will be more tricky. And not committing it now will be a waste 
since this PR will rot very soon.

[~dsmiley] what is your gut feeling for bringing this into 9.0? Do you feel you 
have necessary control over the changes? After reviewing I fear this PR is a 
bit too large and risky. 90% of the changes is boiler-plate and simple, but 
there are some non-trivial changes too.

> Decouple CloudSolrClient from ZkStateReader
> -------------------------------------------
>
>                 Key: SOLR-16061
>                 URL: https://issues.apache.org/jira/browse/SOLR-16061
>             Project: Solr
>          Issue Type: Task
>      Security Level: Public(Default Security Level. Issues are Public) 
>            Reporter: Jan Høydahl
>            Priority: Blocker
>             Fix For: 9.0
>
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> Spinoff from SOLR-15342
> We need to decouple CloudSolrClient from Zookeeper, to prepare for a future 
> modularization of solrj. This should be targetet for 9.0.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to