janhoy commented on a change in pull request #763:
URL: https://github.com/apache/solr/pull/763#discussion_r836542226
##########
File path: dev-tools/scripts/smokeTestRelease.py
##########
@@ -836,12 +827,15 @@ def checkIdenticalMavenArtifacts(distFiles, artifacts,
version):
for artifact in artifacts:
if reJarWar.search(artifact):
artifactFilename = os.path.basename(artifact)
+ if artifactFilename in ['solr-test-framework-%s.jar' % version]:
+ print(' Skipping artifact %s as it should not be in the binary
distribution' % artifactFilename)
Review comment:
Good idea - I added an explicit check (did not test it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
