[ 
https://issues.apache.org/jira/browse/SOLR-16126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17525163#comment-17525163
 ] 

ASF subversion and git services commented on SOLR-16126:
--------------------------------------------------------

Commit 71fb6fd401c182b232952d8e85c6cd5d4b6fa235 in solr's branch 
refs/heads/branch_9x from Michael Gibney
[ https://gitbox.apache.org/repos/asf?p=solr.git;h=71fb6fd401c ]

SOLR-16126: Allow FiltersQParser ({!filters param=[...]}) to tolerate empty 
param args (#777)

(cherry picked from commit 0e6d01cb5715081529d59abf0d73845861c0176f)


> Allow FiltersQParser (`{!filters param=[...]}`) to tolerate empty `param` args
> ------------------------------------------------------------------------------
>
>                 Key: SOLR-16126
>                 URL: https://issues.apache.org/jira/browse/SOLR-16126
>             Project: Solr
>          Issue Type: Improvement
>      Security Level: Public(Default Security Level. Issues are Public) 
>          Components: query parsers
>    Affects Versions: main (10.0)
>            Reporter: Michael Gibney
>            Priority: Minor
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> One common use case for FiltersQParser is to bundle filters and main query, 
> e.g. for passing a single-query domain definition to functions, or for 
> finer-grained control over how logical filters are bundled together.
> Consider the first use case: `\{!filters param=$q param=$fq\}`
> FiltersQParser currently strictly enforces that the referred params must be 
> present and non-empty, and fails hard (throws a {{SyntaxError}}) if this is 
> not the case.
> This issue proposes to relax this enforcement, because:
> # There are legitimate, common use cases for which this requirement is simply 
> an inconvenience (albeit easily worked around by adding a "dummy" 
> {{fq=\*:\*}}), and
> # It's unclear what practical purpose is served by by the current strict 
> enforcement of non-empty params.
> The proposal is to have e.g. `\{!filters param=$fq\}`, in the absence of any 
> non-empty {{fq}} param, be equivalent to {{\*:\*}}.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to