risdenk opened a new pull request, #820:
URL: https://github.com/apache/solr/pull/820

   https://issues.apache.org/jira/browse/SOLR-16169
   
   # Description
   
   An empty `spellcheck.q` parameter results in `NegativeArraySizeException` 
from Lucene. 
   
   # Solution
   
   https://issues.apache.org/jira/browse/LUCENE-10533 is fixing the root cause, 
but we can add protection in Solr as well. This skips doing a spell check if 
the token is empty.
   
   # Tests
   
   Adds tests to explicitly check if spellcheck tokens are empty and short 
circuits if it is.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [ ] I have reviewed the guidelines for [How to 
Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms 
to the standards described there to the best of my ability.
   - [ ] I have created a Jira issue and added the issue ID to my pull request 
title.
   - [ ] I have given Solr maintainers 
[access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork)
 to contribute to my PR branch. (optional but recommended)
   - [ ] I have developed this patch against the `main` branch.
   - [ ] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [ ] I have added documentation for the [Reference 
Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to