[
https://issues.apache.org/jira/browse/SOLR-15660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17534056#comment-17534056
]
Michael Gibney commented on SOLR-15660:
---------------------------------------
... though actually come to think of it, assuming Dawid's conjecture is correct
about "thread is probably still alive when leaks are verified but by the time
the method prints the report, it's terminated", then the underlying cause could
indeed be essentially the same. Even assuming the classes that handle the Jdbc
connection are actually closing everything synchronously, anything handled by a
ThreadPoolExecutor could be detected as a leak in the exact same way as the
stack traces I was focusing on. Once the thread's been detected as a leak, any
superficial difference between the case you were looking at and the case I was
looking at could be accounted for by the race condition between detection and
log printing that Dawid describes.
The takeaway from my perspective is that Dawid's assertion that there "should
be a thread linger annotation on suites that fork threads which cannot be
joined before the test returns" actually describes _a lot_ of cases. Some tests
directly introduce an Executor as part of the test, but in other cases (e.g.,
JdbcTest) there are probably Executors behind third-party or JVM abstractions,
whose threads are completely beyond our ability to {{join()}} on.
> Remove universal 10 second test thread leak linger.
> ---------------------------------------------------
>
> Key: SOLR-15660
> URL: https://issues.apache.org/jira/browse/SOLR-15660
> Project: Solr
> Issue Type: Test
> Components: Tests
> Reporter: Mark Robert Miller
> Assignee: Mark Robert Miller
> Priority: Minor
> Fix For: 9.0
>
> Attachments: screenshot-1.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
