[ 
https://issues.apache.org/jira/browse/SOLR-14699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17536239#comment-17536239
 ] 

Joel Bernstein edited comment on SOLR-14699 at 5/12/22 5:24 PM:
----------------------------------------------------------------

JSON would make parsing a lot less brittle. Exceptions and stack traces are in 
this log as well. Currently postlogs is able to read a stacktrace and assign it 
to an Error log message. Would be good to still be able to do that. Having 
separate Error logs is not a bad idea either. 


was (Author: joel.bernstein):
JSON would make parsing a lot less brittle. Exceptions and stack traces are in 
this log as well. Currently postlogs is able to read a stacktrace and assign it 
to an Error log message. Would be good to still be able to do that. Having 
separate Error logs not a bad idea either. 

> Solr request logs should escape names, values 
> (SolrQueryResponse.getToLogAsString)
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-14699
>                 URL: https://issues.apache.org/jira/browse/SOLR-14699
>             Project: Solr
>          Issue Type: Improvement
>          Components: logging
>            Reporter: David Smiley
>            Priority: Minor
>
> {{SolrQueryResponse.getToLogAsString}} encodes the NamedList into a String 
> with simple space-separated pairs with name=value.  However, it does no 
> escaping/encoding, and as-such a value might itself contain spaces and 
> equals.  This is a problem if these logs are being parsed, and we'd like to 
> ensure we do so correctly.  Note that SolrLogPostTool (aka "postlogs") parses 
> these logs.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to