dsmiley commented on code in PR #882:
URL: https://github.com/apache/solr/pull/882#discussion_r894843028
##########
solr/core/src/java/org/apache/solr/util/SolrLogPostTool.java:
##########
@@ -278,48 +279,71 @@ private void parseError(SolrInputDocument lineRecord,
String line, String trace)
if (this.cause != null) {
lineRecord.setField("root_cause_t", cause.replace("Caused by:",
"").trim());
}
-
- lineRecord.setField("collection_s", parseCollection(line));
- lineRecord.setField("core_s", parseCore(line));
- lineRecord.setField("shard_s", parseShard(line));
- lineRecord.setField("replica_s", parseReplica(line));
}
- private void parseQueryRecord(SolrInputDocument lineRecord, String line) {
- lineRecord.setField("qtime_i", parseQTime(line));
- lineRecord.setField("status_s", parseStatus(line));
+ private Map<String, Object> extractJsonFormattedMessage(String line) {
+ int startPos = line.indexOf('{'); // '{' starts at
+ int endPos = line.lastIndexOf('}'); // '}' ends at
Review Comment:
Might? Why exactly? If a space shows up, we have control in Solr to ensure
it doesn't. If you are seeing a space in fact, check the logging format
pattern. The message should go exactly last with nothing following. LMK if
I'm wrong about this please.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
