cpoerschke commented on code in PR #875:
URL: https://github.com/apache/solr/pull/875#discussion_r897146326
##########
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##########
@@ -102,4 +104,50 @@ public void close() {}
}
log.info("QuerySenderListener done.");
}
+
+ private List<NamedList<Object>> convertQueriesToList(ArrayList<Object>
queries) {
Review Comment:
minor: could this be `static` perhaps?
```suggestion
private static List<NamedList<Object>>
convertQueriesToList(ArrayList<Object> queries) {
```
##########
solr/core/src/java/org/apache/solr/core/QuerySenderListener.java:
##########
@@ -102,4 +104,50 @@ public void close() {}
}
log.info("QuerySenderListener done.");
}
+
+ private List<NamedList<Object>> convertQueriesToList(ArrayList<Object>
queries) {
+
+ List<NamedList<Object>> allLists = new ArrayList<NamedList<Object>>();
+
+ for (Object o : queries) {
+ switch (o.getClass().getName()) {
+ case "java.util.ArrayList":
Review Comment:
Wondering if `o instanceof ArrayList` or `o instanceof List` might be an
alternative to the `case "java.util.ArrayList":` here, or if not would be great
to have a short comment in the code noting why the class name is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
