[ https://issues.apache.org/jira/browse/SOLR-15738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17556986#comment-17556986 ]
Jason Gerlowski commented on SOLR-15738: ---------------------------------------- I've merged a PR for 'main' and 'branch_9x'. One question I wanted to close the loop on: bq. JWTAuthPlugin, RuleBasedAuthorizationPlugin and others popular plugins in core implement SpecProvider today I left these interface declarations alone for now. It might be ripe ground to refactor down the road, but I found a way to implement the {{getSpec}} method for these plugins somewhat naturally. So while we might be able to remove the interface at some point, it didn't end up being as unnatural in this PR as I initially suspected it might. > Rewrite security APIs using annotation framework > ------------------------------------------------ > > Key: SOLR-15738 > URL: https://issues.apache.org/jira/browse/SOLR-15738 > Project: Solr > Issue Type: Sub-task > Components: v2 API > Reporter: Jason Gerlowski > Assignee: Jason Gerlowski > Priority: Major > Labels: V2 > Time Spent: 2.5h > Remaining Estimate: 0h > > Solr's v2 APIs can be implemented in 1 of 2 possible ways: an apispec (i.e. > JSON file) based approach that was originally conceived when the v2 APIs were > created, and an approach that relies on annotated POJO objects which has come > into favor more recently as it results in less duplication and inches our > APIs ones step towards a more strongly-typed future. > The consensus has emerged across several JIRAs that the annotated-POJO > approach is the one that should be used going forward, and that existing v2 > APIs should be cut over as convenient. > It's worth noting that this will cause the introspection output to lose the > "description" text for these APIs and their parameters, as there's no support > for this yet for annotation-based v2 APIs. See SOLR-15117 for more details. > This ticket aims to tackle this conversion for the Solr's various > security-related APIs. -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org