anshumg commented on code in PR #34:
URL: https://github.com/apache/solr-sandbox/pull/34#discussion_r948336224
##########
CROSSDC.md:
##########
@@ -117,6 +117,14 @@ Additional configuration properties:
*groupId* - the group id to give Kafka for the consumer, default to the
empty string if not specified.
+The following additional configuration properties should either be specified
for both the producer and the consumer or in the shared Zookeeper
+central config properties file. This is because the Consumer will use a
Producer for retries.
+
+ *batchSizeBytes* - the maximum batch size in bytes for the queue
+ *bufferMemoryBytes* - the amount of memory in bytes allocated by the
Producer in total for buffering
+ *lingerMs* - the amount of time that the Producer will wait to add to a
batch
+ *requestTimeout* -
Review Comment:
Do you want to add a description to `requestTimeout` ?
##########
crossdc-commons/src/main/java/org/apache/solr/crossdc/common/KafkaCrossDcConf.java:
##########
@@ -16,25 +16,49 @@
*/
package org.apache.solr.crossdc.common;
+import org.apache.kafka.clients.producer.ProducerConfig;
+
public class KafkaCrossDcConf extends CrossDcConf {
+
+ public static final String DEFAULT_BATCH_SIZE_BYTES = "512000";
Review Comment:
Do these need to be String ?
##########
crossdc-commons/src/main/java/org/apache/solr/crossdc/common/KafkaCrossDcConf.java:
##########
@@ -16,25 +16,49 @@
*/
package org.apache.solr.crossdc.common;
+import org.apache.kafka.clients.producer.ProducerConfig;
+
public class KafkaCrossDcConf extends CrossDcConf {
+
+ public static final String DEFAULT_BATCH_SIZE_BYTES = "512000";
Review Comment:
All other places have the same pattern. Should we change all of these out in
another PR ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
