gerlowskija commented on code in PR #975:
URL: https://github.com/apache/solr/pull/975#discussion_r965936792
##########
solr/core/src/java/org/apache/solr/jersey/CatchAllExceptionMapper.java:
##########
@@ -93,10 +98,12 @@ public Response toResponse(Exception exception) {
RequestHandlerBase.processErrorMetricsOnException(normalizedException,
metrics);
}
- // Then, convert the exception into a SolrJerseyResponse (creating one as
necessary if resource was matched, etc.)
- final SolrJerseyResponse response =
containerRequestContext.getProperty(SOLR_JERSEY_RESPONSE_KEY) == null ?
- new SolrJerseyResponse() :
- (SolrJerseyResponse)
containerRequestContext.getProperty(SOLR_JERSEY_RESPONSE_KEY);
+ // Then, convert the exception into a SolrJerseyResponse (creating one as
necessary if resource
+ // was matched, etc.)
Review Comment:
I reformatted this a bit and chose a new place to break the line so it looks
a little more even, but it still looks a bit awkward. I wish spotless allowed
longer lines for comments (or in general).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
