gerlowskija commented on code in PR #975: URL: https://github.com/apache/solr/pull/975#discussion_r967291913
########## solr/core/src/java/org/apache/solr/jersey/ApplicationEventLogger.java: ########## @@ -0,0 +1,51 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.solr.jersey; + +import java.lang.invoke.MethodHandles; +import org.glassfish.jersey.server.monitoring.ApplicationEvent; +import org.glassfish.jersey.server.monitoring.ApplicationEventListener; +import org.glassfish.jersey.server.monitoring.RequestEvent; +import org.glassfish.jersey.server.monitoring.RequestEventListener; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Logs out application-level information useful for troubleshooting Jersey development. + * + * @see RequestEventLogger + */ +public class ApplicationEventLogger implements ApplicationEventListener { + private static final Logger log = LoggerFactory.getLogger(MethodHandles.lookup().lookupClass()); + + private volatile long requestCount = 0; Review Comment: On second thought I've decided to just cut these classes. The sort of information they log was very helpful in tracking resource registration and understanding how resources are looked up at request time, but very few users should need that now that the framework will be in place. (If we do want them later, they're trivial for an IDE to generate from Jersey's ApplicationEventListener and RequestEventListener interfaces, so there'll be no real loss if we need to "180" on this later.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
