NazerkeBS commented on PR #977: URL: https://github.com/apache/solr/pull/977#issuecomment-1249377813
> Thanks for the detailed doc, @NazerkeBS ! > > I've left review comments but additionally, it'd be best to mention that this explanation assumes the user is splitting the parent shard into 2 parts using the 'default' settings. > > Also, considering this dives into an implementation detail I fear this would get out of sync at some point and would be tough to maintain. Let that not stop you from contributing this but I wanted to bring that up as a concern. > > Overall, this is would be really useful for folks trying to understand SPLITSHARD. Thanks @anshumg for your review. I updated the PR based on your comments. I agree it would be a concern to maintain this doc over time as code changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
