tflobbe commented on code in PR #1047:
URL: https://github.com/apache/solr/pull/1047#discussion_r983941212
##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -451,22 +451,24 @@ public NamedList<Object> request(SolrRequest<?>
solrRequest, String collection)
final ResponseParser parser =
solrRequest.getResponseParser() == null ? this.parser :
solrRequest.getResponseParser();
+ Throwable abortCause = null;
try {
InputStreamResponseListener listener = new InputStreamResponseListener();
req.send(listener);
Response response = listener.get(idleTimeout, TimeUnit.MILLISECONDS);
InputStream is = listener.getInputStream();
assert ObjectReleaseTracker.track(is);
-
return processErrorsAndResponse(solrRequest, parser, response, is);
} catch (InterruptedException e) {
Thread.currentThread().interrupt();
+ abortCause = e;
throw new RuntimeException(e);
} catch (TimeoutException e) {
Review Comment:
I missed it here. I think it may not be needed, because TimeoutExceptions,
from what I can see, already abort the request, but it's no harm to have the
abort in this case too, worst case it'll be a noop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
