anshumg commented on code in PR #1046: URL: https://github.com/apache/solr/pull/1046#discussion_r983956769
########## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ########## @@ -519,7 +525,11 @@ private Request makeRequest(SolrRequest<?> solrRequest, String collection) private void decorateRequest(Request req, SolrRequest<?> solrRequest) { req.header(HttpHeader.ACCEPT_ENCODING, null); - req.timeout(idleTimeout, TimeUnit.MILLISECONDS); + if (requestTimeout > 0) { Review Comment: If someone accidentally sets this to 0, we'd just be ignoring it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org