gerlowskija commented on PR #48:
URL: https://github.com/apache/solr-sandbox/pull/48#issuecomment-1274775794

   > I was thinking about checking the size of the Solr request in 
MURPF.getInstance() and setting a bool to make the URP a no-op at the start but 
this solution is fine for now.
   
   I do like this approach better in hindsight.  I hadn't realized at the time 
of writing that the Factory would have access to the whole batch.  Much cleaner 
to keep this out of the processor itself.
   
   That said, since the intention is that this feature only be a stop gap while 
we work "on an ideal solution that's cleaner and more reasonable," I'll leave 
it as-is for now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to