janhoy commented on code in PR #1066:
URL: https://github.com/apache/solr/pull/1066#discussion_r993515430


##########
solr/docker/templates/Dockerfile.body.template:
##########
@@ -45,6 +45,7 @@ ENV SOLR_USER="solr" \
     SOLR_PID_DIR=/var/solr \
     SOLR_LOGS_DIR=/var/solr/logs \
     LOG4J_PROPS=/var/solr/log4j2.xml \
+    SOLR_SERVER_DIR="/opt/solr-${SOLR_VERSION}/server" \

Review Comment:
   I see. So Java does not understand symlinks.. Could we instead of setting 
this SOLR_SERVER_DIR, open up `/opt/solr-${SOLR_VERSION}/` in the security 
manager, so both the canonical and the symlink paths are explicitly allowed? It 
feels safer. I.e. something like this
   
   ```java
     permission java.io.FilePermission "/opt/solr-*", 
"read,write,delete,readlink";
     permission java.io.FilePermission "/opt/solr-*${/}-", 
"read,write,delete,readlink";
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to