[ https://issues.apache.org/jira/browse/SOLR-16305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17617252#comment-17617252 ]
Chris M. Hostetter commented on SOLR-16305: ------------------------------------------- {quote}No, I meant that they cannot be set as DocCollection properties, they are silently skipped there (wihle they are indeed propagated to cores). If you want to set a DocCollection property you have to use MODIFYCOLLECTION, and while this works for setting `property.*` in DocCollection it indeed does not propagate these custom props to cores. {quote} Ah, ok – so in the context of your earlier comment, your perception of what "works" is completely different then what this Jira was opened to track. : ) ---- The documented purpose of {{property.name=value}} params when doing a CREATE action in the collection API is... {quote}Set *core property* _name_ to {_}value{_}. See the section [Core Discovery|https://solr.apache.org/guide/solr/latest/configuration-guide/core-discovery.html] for details on supported properties and values. {quote} ...where Core Discovery says that the purpose of custom "user defined properties" is... {quote}user-defined properties may be specified for use as variables. For more information on how to define local properties, see the section [Property Substitution in Configuration Files|https://solr.apache.org/guide/solr/latest/configuration-guide/property-substitution.html]. {quote} Meanwhile the documented purpose of \{{property.name=value}} params when doing a MODIFYCOLLECTIOn action just says... {quote}See the [CREATE action|https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.html#create] section {quote} So it's pretty clear – both from remembered history and from the docs – that the purpose of allowing these custom {{property.name=value}} params in the collection API is to put them in the {{core.properties}} files so they can be used as variables in config files during core load. ---- AYou're talking about when/why/how these custom properties (sometimes, only i nthe case of MODIFYCOLLECTION) make it into {{DocCollection}} objects (in memory) in solr ... but do we have any documented reason why/when/how it matters if a custom {{property.name=value}} is in the {{DocCollection}} ? Does anything/anywhere in the docs say "use MODIFYCOLLECTIOn to set custom name=values properties so that they are in DocCollection" or "if a custom name=value property is in DocCollection you can use it for...." ? Should this Jira have a linked "converse" issue: "CREATE collection with property.* doesn't set values in DocCollection (even though MODIFYCOLLECTION can cahnge them)" ? ---- (FWIW: i also still don't really understand WTF the {{COLLECTIONPROP}} command's purpose / expected usage is? it's documented that the action exists, not when/why/how it matters) > MODIFYCOLLECTION with 'property.*' changes can't change values used in config > file variables (even though they can be set during collection CREATE) > --------------------------------------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-16305 > URL: https://issues.apache.org/jira/browse/SOLR-16305 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Reporter: Chris M. Hostetter > Priority: Major > Attachments: SOLR-16305_test.patch > > > Consider a configset with a {{solrconfig.xml}} that includes a snippet like > this... > {code:java} > <str name="param.check">${custom.prop:customDefVal}</str> > {code} > ...this {{custom.prop}} can be set when doing a {{CREATE}} command for a > collection that uses this configset, using the {{property.*}} prefix as noted > in the reg-guide... > {quote}{{property.{_}name{_}={_}value{_}}} > |Optional|Default: none| > Set core property _name_ to {_}value{_}. See the section [Core > Discovery|https://solr.apache.org/guide/solr/latest/configuration-guide/core-discovery.html] > for details on supported properties and values. > {quote} > ...BUT.... > These values can *not* be changed by using the {{MODIFYCOLLECTION}} command, > in spite of the ref-guide indicating that it can be used to modify custom > {{property.*}} attributes... > {quote}The attributes that can be modified are: > * {{replicationFactor}} > * {{collection.configName}} > * {{readOnly}} > * other custom properties that use a {{property.}} prefix > See the [CREATE > action|https://solr.apache.org/guide/solr/latest/deployment-guide/collection-management.html#create] > section above for details on these attributes. > {quote} -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org