risdenk commented on PR #947:
URL: https://github.com/apache/solr/pull/947#issuecomment-1279651282

   I added forbiddenapis and went down the rabbit hole w/ this.
   
   So we can't override assertThat in SolrTestCase since its static and comes 
from Assert which is what LuceneTestCase derives from. ForbiddenApis correctly 
complains that we can't just override the static method and instead knows that 
Assert#assertThat is still being called. So the solution in this PR isn't going 
to work as is. 
   
   The MatcherAssert.assertThat static import also doesn't work in each file 
since the base class already has the static method assertThat - so the only 
solution is to explicitly do MatcherAssert.assertThat.
   
   I have a change that does that that I'll push shortly including the 
forbiddenapis check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org

Reply via email to