risdenk commented on PR #953:
URL: https://github.com/apache/solr/pull/953#issuecomment-1284423921
@mkhludnev so two items from your review that I haven't addressed. One I
don't think I can fix. The other I'm open to changing to static imports if
really desired.
Changes like `assertEquals(3, (long) tuple.getLong("myId"));` - I left a
comment about how I don't see a way to fix this outside of doing
`Long.valueOf(3)` which seems worse. Are you ok with going ahead with this PR
without this being changed to not have a cast?
The second being changes like `SolrTestCaseJ4.assertNotNull` where I had
removed the static import and qualified these. How strongly do you feel about
these being `assertNotNull` vs leaving the `SolrTestCaseJ4.assertNotNull`
qualification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
