janhoy commented on PR #1090: URL: https://github.com/apache/solr/pull/1090#issuecomment-1284643327
> Could we maybe make this only be applied after Java 17? I think we have Java version checks before, so it should be a simple if statement. > > This would be a good exercise for JDK 19 and MMapDirectory, where we need `--enable-preview` to use it (only on that version). I made the workaround conditional on java version. Tested `bin/solr` but did not get a chance to test `bin\solr.cmd`, perhaps you can test it Uwe? Start Solr on JDK11 and JDK17 and see that the start script prints "...Enabled workaround for SOLR-16463" on v17, and that you find the `-XX:CompileCommand` flag in the args list http://localhost:8983/solr/admin/info/system -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
