[
https://issues.apache.org/jira/browse/SOLR-16347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17622321#comment-17622321
]
Jason Gerlowski commented on SOLR-16347:
----------------------------------------
I'm interested in backporting but I held off in reluctant deference to Ishan's
request - not just until branch_9_1 was cut, but until 9.1 is all but finalized.
Ishan's concern was that JAX-RS changes wouldn't affect the 9.1 release, but
they might make it harder for some other unrelated 9.1 bugfix to land if it has
to go through branch_9x. See the comment
[here|https://issues.apache.org/jira/browse/SOLR-16347?focusedCommentId=17611228&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-17611228].
(On second thought though, does this make sense? I held off backporting to
branch_9x on the off chance it'd make other folks' backports easier, but the
JAX-RS stuff is on 'main', which 9.1 bugfixes would also presumably have to
deal with? So, idk.)
[~ichattopadhyaya] how do you feel about backports to branch_9x at this point?
Are you more comfortable with this now, given that you're nearing the first RC?
What do you think about my point above regarding 'main' - I don't think I'd
thought through that aspect earlier when we discussed...
And [~houston], is the main/branch_9x divergence causing you issues in some
way? If not-backporting is causing inconvenience for folks, I'm happy to do it
as it almost surely outweighs the theoretical "risk" of slowing down other 9.1
bugfixes.
> Add JAX-RS integration for defining v2 APIs
> -------------------------------------------
>
> Key: SOLR-16347
> URL: https://issues.apache.org/jira/browse/SOLR-16347
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: v2 API
> Affects Versions: main (10.0)
> Reporter: Jason Gerlowski
> Assignee: Jason Gerlowski
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> SOLR-15182 rewrote our v2 APIs to use annotations using an existing
> (in-house) framework. But continuing to use a homegrown framework is less
> than ideal for a few reasons:
> # Our in-house framework doesn't integrate with 3rd-party tooling like
> OpenAPI.
> # It gives us less functionality than many off-the-shelf frameworks, at a
> higher maintenance cost.
> # The current framework is less explicit about API inputs and outputs than
> many off-the-shelf alternatives, making code less clear and readable for
> developers.
> (For more on the pros/cons and for different evaluations on the tradeoff
> here, see
> [this|https://lists.apache.org/thread/6wx2vzfnmfgkw03b7s450zfp7yhrlz8f]
> long-running dev@ thread.)
> The work done by SOLR-15182 makes the jump to JAX-RS reasonably
> straightforward on an individual API basis: once the framework is in place
> switching a given API to JAX-RS is mostly a matter of swapping out our
> homegrown annotations for those recognized by JAX-RS and changing API method
> signatures to better represent the API inputs/outputs.
> We should integrate Jersey or a similar JAX-RS implementation and start
> cutting over v2 APIs to this new mode of definition.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
