risdenk commented on code in PR #585: URL: https://github.com/apache/solr/pull/585#discussion_r1002074641
########## solr/server/etc/jetty.xml: ########## @@ -178,7 +178,7 @@ </New> </Item> <Item> - <New id="InstrumentedHandler" class="com.codahale.metrics.jetty9.InstrumentedHandler"> + <New id="InstrumentedHandler" class="com.codahale.metrics.jetty10.InstrumentedHandler"> Review Comment: Ugh @epugh found that this is broken - it needs to be `io.dropwizard.metrics.jetty10.InstrumentedHandler` ########## versions.props: ########## @@ -17,14 +17,13 @@ commons-cli:commons-cli=1.4 commons-codec:commons-codec=1.15 commons-collections:commons-collections=3.2.2 commons-io:commons-io=2.11.0 -io.dropwizard.metrics:*=4.1.5 +io.dropwizard.metrics:*=4.2.12 Review Comment: Needed for metrics-jetty10 ########## versions.props: ########## @@ -68,5 +68,7 @@ org.openjdk.jmh:*=1.32 org.quicktheories:quicktheories=0.26 org.semver4j:semver4j=2.1.1 org.slf4j:*=1.7.36 +org.springframework.boot:spring-boot*=2.5.14 +org.springframework:spring*=5.3.23 Review Comment: Needed for s3mock? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org