epugh opened a new pull request, #1107: URL: https://github.com/apache/solr/pull/1107
https://issues.apache.org/jira/browse/SOLR-9775 # Description This is brought over from https://github.com/apache/lucene-solr/pull/116/files # Solution I feel like I am pulling a thread on a sweater..... It feels odd that we have so much handling around nulls.... And that this whole thing needs some refactoring so there aren't nulls. In fact, there is kind of a comment about this in `QueryResultKey.unorderedCompare()`: ``` // SOLR-5618: if we had a guarantee that the lists never contained any duplicates, // this logic could be a lot simpler // // (And of course: if the SolrIndexSearcher / QueryCommand was ever changed to // sort the filter query list, then this whole method could be eliminated). ``` It feels like if we simplified the types of objects passed into the `QueryResultKey` this would all be simpler. It's literally just a key! # Tests Existing tests, and then added some to demonstrate the NPE and then the fix... # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
