gezapeti commented on code in PR #1108:
URL: https://github.com/apache/solr/pull/1108#discussion_r1002375679
##########
solr/core/src/java/org/apache/solr/cloud/api/collections/SplitShardCmd.java:
##########
@@ -199,8 +200,17 @@ public boolean split(ClusterState clusterState,
ZkNodeProps message, NamedList<O
"SplitShardCmd: verify that there is enough space on disk to
create sub-shards for slice: {}",
parentShardLeader);
t = timings.sub("checkDiskSpace");
- checkDiskSpace(
- collectionName, slice.get(), parentShardLeader, splitMethod,
ccc.getSolrCloudManager());
+ boolean skipFreeSpaceCheck = message.getBool(SKIP_FREE_SPACE_CHECK,
false);
Review Comment:
Oh, I haven't seen the other check, I've just applied my earlier changes.
Now I wonder if this per-call granularity is necessary in this logic. I can see
the advantage that retrying a shard split with this error does not require a
restart with this parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
For additional commands, e-mail: issues-h...@solr.apache.org
