iamsanjay opened a new pull request, #1119: URL: https://github.com/apache/solr/pull/1119
https://issues.apache.org/jira/browse/SOLR-16461 <!-- _(If you are a project committer then you may remove some/all of the following template.)_ Before creating a pull request, please file an issue in the ASF Jira system for Solr: * https://issues.apache.org/jira/projects/SOLR For something minor (i.e. that wouldn't be worth putting in release notes), you can skip JIRA. To create a Jira issue, you will need to create an account there first. The title of the PR should reference the Jira issue number in the form: * SOLR-16461: Create v2 equivalent of v1 ReplicationHandler 'BACKUP' SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on. Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. --> # Description A backup API for user manager cluster or single node installation has no v2 equivalent. This ticket is used to track changes that will be made to add the v2 API for the 'backup'. v1 Existing Form ``` /solr/{coreName}/replication?command=backup` ``` to: ``` /api//cores/{coreName}/replication/backups ``` # Solution This PR adds v2 endpoints for Backup (via ReplicationHandler) using new JAS-RX framework. In JAS-RX api we inject core container and then through `CoreContainer`, an object of `ReplicationHandler` is injected inside API. After getting access to the ReplicationHandler, a method named `handleRequestBody` is called to handle the backup. Note:- Currently this PR is in draft mode as the injection is failing while creating API object. We are working on this. # Tests It's still work in progress. Currently test is failing because of injection issues. But there is one test case added which calls the v2 endpoints and assert following in the returned response. - Status Code on successful backup - Content type - Response JSON # Checklist Please review the following and check all that apply: - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [x] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [x] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
