dsmiley commented on PR #1121: URL: https://github.com/apache/solr/pull/1121#issuecomment-1290873232
Can we please consider not using String.format here at all? String.format is useful when there is non-trivial formatting. I don't think we should use String.format when a trivial String concatenation can do the job. I don't understand why some people reach for more complex tools like this when the language itself is adequate. We wouldn't even need a test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
